Reviewed...
Renaming ir.exe.config feels a bit scary. If the user does Ctrl-C, the build
will be in a bad state. I think it shouldn't be too hard to copy ir.exe and the
required dlls to a new folder, right? That would be preferable.
For the legacy tests, we should do a code coverage anaylsis to see if they have
any value, or if we can nuke them.
Can irtests.rb print the total elapsed time? I find it very useful to know how
long the command is going to take (since it's a long running command)...
Tomas, do you run tests in parallel? I have not been using "-p" and wouldn't
mind getting rid of it.
"System::Array.of(System::String).new(["a".to_clr_string,"b".to_clr_string])"
could be factored to something like clr_strings("a", "b") to make it concise
From: Jim Deville
Sent: Thursday, June 11, 2009 10:40 AM
To: [email protected]
Cc: IronRuby External Code Reviewers
Subject: RE: CR: Various Git commits
Since no one has reviewed this, I've added one more:
add test to ensure that basic IronRuby works without
ir.exe.config<http://github.com/jredville/ironruby/commit/655a5fe62500999f4e0f1ecd320b0d834a616e2c>
JD
...there is no try
From: Jim Deville
Sent: Wednesday, June 10, 2009 10:44 PM
To: [email protected]
Cc: IronRuby External Code Reviewers
Subject: CR: Various Git commits
* refactor irtests into a ruby
script<http://github.com/jredville/ironruby/commit/24d206a4a9abb9098dc9be111a8802eedaf0a5ce>
* hook up test tasks, change default to run tests, make git:commit run
tests, namespace compilation, fix
IronRuby.Test.exe<http://github.com/jredville/ironruby/commit/fae95e33ca55a56827fe55f578adc03bc555af5b>
* Most of IronPython now compiles with rake compile. We are only
missing IronPythonTest.dll, which may be
ok<http://github.com/jredville/ironruby/commit/867cca3db10c11852dd7bc1a3312c70c60056e54>
* Adding more interop tests for delegate creation and invocation. Also
adds IronPython compilation to rake
git:commit<http://github.com/jredville/ironruby/commit/cca26471b37fc63dc0500dd35689d29653a9b060>
* Make legacy tests work from
rake<http://github.com/jredville/ironruby/commit/7f622eb8e804f973135f76154eed45185b57a147>
* split apps into two component tasks for
granularity<http://github.com/jredville/ironruby/commit/39cab49e840adcad32da6aba5d6519ab29b5702e>
JD
...there is no try
_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core
