MutableString already has RequireNotFrozen method. You don't need to add it to MutableStringOps.
There already is a check in Translate and TrSequezeInPlace: self.RequireNotFrozen(); Tomas -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Shri Borde Sent: Thursday, July 16, 2009 2:42 PM To: [email protected] Subject: Re: [Ironruby-core] Review: misc fixes to MutableStringOps.cs I see. OK then. -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of Daniele Alessandri Sent: Thursday, July 16, 2009 2:39 PM To: [email protected] Subject: Re: [Ironruby-core] Review: misc fixes to MutableStringOps.cs On Thu, Jul 16, 2009 at 23:25, Shri Borde<[email protected]> wrote: > Could you update BlockReplaceInPlace in MutableStrinOps.cs to also use > RequiresNotFrozenString? BlockReplaceInPlace seems correct as is to me, String#gsub! raises a RuntimeError instead of a TypeError when self is frozen. -- Daniele Alessandri http://www.clorophilla.net/blog/ http://twitter.com/JoL1hAHN _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
