Looks good. Tomas
From: Shri Borde Sent: Thursday, July 23, 2009 2:26 PM To: [email protected] Cc: IronRuby External Code Reviewers Subject: Review: Fixes HTTP.post_form http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b Fixes HTTP.post_form (http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1353). Socket#write was not flushing the data, and so a later read could block since the endpoint would not send any response Files changed: * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/critical_tags.txt<http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-0> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/ftp/get_tags.txt<http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-1> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/ftp/getbinaryfile_tags.txt<http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-2> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/ftp/retrbinary_tags.txt<http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-3> * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/get_print_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/lock_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/post_form_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/post_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/propfind_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/proppatch_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/put_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/request_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/send_request_tags.txt * Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/ironruby-tags/library/net/http/http/unlock_tags.txt * Merlin/Main/Languages/Ruby/Libraries.LCA_RESTRICTED/socket/SocketStream.cs<http://github.com/shri/ironruby/commit/74d580cebe5dc74dbf6ce67399159dfc8ce8686b#diff-14> Thanks, Shri
_______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
