I have a commit which hopefully addresses these concerns: http://github.com/kradcliffe/ironruby/commit/5bbe752c286967f30b01b88bde2ed6f287ecbb4e
Cleaned up OpenSSL::SSL specs a bit, and added a couple of specs for net/https (to catch corner case errors) Files Added: Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/net/https/ssl_timeout_spec.rb Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/net/https/use_ssl_spec.rb Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/openssl/ssl/sslcontext_spec.rb Files Deleted: Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/openssl/ssl/sslcontext/context_spec.rb Files Changed: Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/openssl/ssl/constant_spec.rb Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/openssl/ssl/type_spec.rb <http://github.com/kradcliffe/ironruby/commit/5bbe752c286967f30b01b88bde2ed6f287ecbb4e> On Thu, Aug 20, 2009 at 4:25 PM, Shri Borde <[email protected]>wrote: > In type_spec, “OpenSSL::SSL.should == OpenSSL::SSL” is a noop. Please > remove the test (unless I am missing something about why this is valuable). > > > > In constant_spec.rb, please also add tests comparing the constant to some > literal value. The current spec only ensures that the two sets of constants > are consistent, but not that they are the right value. > > > > Can any of the net/https tests be enabled? Enabling those would be great so > that we ensure that we do not break some other code path of net/https. > Otherwise, it looks a fine first cut for a shell implementation. > > > > Thanks for pushing through on getting a clean irtests run!! > > > > *From:* [email protected] [mailto: > [email protected]] *On Behalf Of *Kevin Radcliffe > *Sent:* Thursday, August 20, 2009 3:16 PM > *To:* [email protected] > *Subject:* [Ironruby-core] Code Review: SSLContext shell and basic specs > > > > > http://github.com/kradcliffe/ironruby/commit/39c45cd08877af633437b62dd1fb7e8787863985 > > > > > > Provides a shell as a placeholder for the eventual implementation of > > OpenSSL::SSL::SSLContext. This gives better compatibility for some HTTP client > > gems like: > > httparty and rest-client. > > This should also add some benefit for the standard net/https library > > > > There are also some very basic specs included to flesh out what is needed for > > SSLContext. > > > > > > > > Files Changed: > > > Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/openssl/shared/constants.rb > > Merlin/Main/Languages/Ruby/Libs/openssl.rb > > > > Files Added: > > > Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/openssl/ssl/constant_spec.rb > > > Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/openssl/ssl/sslcontext/context_spec.rb > > > Merlin/External.LCA_RESTRICTED/Languages/IronRuby/mspec/rubyspec/library/openssl/ssl/type_spec.rb > > > > > > > > -Kevin > > > _______________________________________________ > Ironruby-core mailing list > [email protected] > http://rubyforge.org/mailman/listinfo/ironruby-core > >
_______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
