http://github.com/tnachen/ironruby/commit/1323df51a7abf6394f27468a1bda788f4bba9aa9
Revised commit based on feedback. Thanks! Tim From: [email protected] [mailto:[email protected]] On Behalf Of Shri Borde Sent: Thursday, September 03, 2009 2:25 PM To: [email protected] Subject: Re: [Ironruby-core] Code review: IronRuby Tutorial - Loading assemblies by given path The load_*_path and load_*_relative_path functions should now be refactored as there are multiple repetitions now. You should replace the line "The source code of this class library is located ..." with a :source_files argument which is meant exactly for this purpose. You do have ":source_files => IronRubyTutorial.load_xml_path" for the next task, but it references an unrelated file (load.xml) and there is no need to use :source_files at all here. Opening braces in Primes.cs should be on previous line. Also IsPrime should be a static method. Not a big deal as it's a sample, but better to use the same consistent code patterns as the product sources... Great to see your first patch! From: [email protected] [mailto:[email protected]] On Behalf Of Tim Chen (SDO) Sent: Thursday, September 03, 2009 2:09 PM To: [email protected] Subject: [Ironruby-core] Code review: IronRuby Tutorial - Loading assemblies by given path http://github.com/tnachen/ironruby/commit/8e88e52fed4f22d737487e6c7e74762419783e8d http://github.com/tnachen/ironruby/commit/5b19fbd26b4680eaa64ef7d50215cbb2fe36867a Added a small chapter in the tutorial, to load custom class library and interact with it. Tim
_______________________________________________ Ironruby-core mailing list [email protected] http://rubyforge.org/mailman/listinfo/ironruby-core
