Will simplify. Tomas
-----Original Message----- From: Dino Viehland Sent: Wednesday, October 14, 2009 12:43 PM To: Tomas Matousek; IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core@rubyforge.org Subject: RE: Code Review: BF2 My only comment is that this is a pretty complicated expression to have to read: (parameterRequiredModifiers ?? (parameterRequiredModifiers = new Type[paramInfos.Length][]))[i] = mods; But it otherwise looks good. > -----Original Message----- > From: Tomas Matousek > Sent: Wednesday, October 14, 2009 12:15 PM > To: IronRuby External Code Reviewers; Rowan Code Reviewers > Cc: ironruby-core@rubyforge.org > Subject: Code Review: BF2 > > tfpt review "/shelveset:BF2;REDMOND\tomat" > Comment : > Python, DLR: > Fixes Dev10 build. > Fixes bug > http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=772 - new type > builder doesn't handle modops correctly. > > Ruby: > Fixes bugs: > > http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=616 > http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2163 > http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=772 > http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2753 > > Tomas _______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
