This should actually be: tfpt review "/shelveset:DF.4;REDMOND\tomat"
Tomas -----Original Message----- From: Tomas Matousek Sent: Friday, October 16, 2009 4:26 PM To: IronRuby External Code Reviewers; Rowan Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Code Review: BF.3 tfpt review "/shelveset:BF.3;REDMOND\tomat" Comment : DLR: Fixes ScriptScope's BindSetMember - it needs to convert the result expression to Object. Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2421 - if a CLR array is passed to params-array parameter it is not treated as a single parameter. Instead the overload resolver "splats" it by default (implements C# semantics). This is not the right behavior for Ruby. I've added ExpandParams virtual method that allows the language to specify for a given MethodCandidate whether its params array/dictionary should always be expanded and thus never use the incoming array as the params array. Interpreter - implements TypeIs instruction (fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2462). Ruby: Moves methods related to libraries from RubyModule to the library initializer. Fixes http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1849 http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2243 http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2171 http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=1989 http://ironruby.codeplex.com/WorkItem/View.aspx?WorkItemId=2146 Tomas _______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
