Reviewed on GitHub From: Jim Deville Sent: Friday, October 23, 2009 12:36 PM To: IronRuby External Code Reviewers; ironruby-core@rubyforge.org Subject: RE: Code Review: Interop specs
And one more: http://github.com/jredville/ironruby/commit/ed7f6e590d7dffea4503f96e0276dd984353d1e1 JD From: Jim Deville Sent: Friday, October 23, 2009 8:44 AM To: IronRuby External Code Reviewers; ironruby-core@rubyforge.org Subject: Code Review: Interop specs Looking for code review on the following commits. These are net-interop binding specs and bug regression specs. Thanks, JD * remove extraneous 1 file<http://github.com/jredville/ironruby/commit/98aaf7353c6d3808f891aa0c1280eccdee2b30d0> * Cleaning up legacy tests to remove duplication.<http://github.com/jredville/ironruby/commit/7e032918fb76fa7accaad152d37885275daa4692> * A few constraint generic specs.<http://github.com/jredville/ironruby/commit/3e07e3b51a386e6e9c337080add7d8526ed1bfcd> * Matchers and shared cleanup<http://github.com/jredville/ironruby/commit/d0cf7a0d43de550cdbe32c432a93ecd709b31780> * Generic Type inference fixtures and specs.<http://github.com/jredville/ironruby/commit/fce33a590e238be81336b3ddb43fcb6b100c46f7> * refactor specs to use only one args method<http://github.com/jredville/ironruby/commit/987d301f4315ed20d0ed62620a7112c93985788b> * specs for properties and methods on structs and interfaces<http://github.com/jredville/ironruby/commit/3ef3f1d25d93575f752005e7c6b543880f08fcfb> * fixes dev.ps1.<http://github.com/jredville/ironruby/commit/680d5439ba141d5c4b88f2073eeb2d7cda886920> * Specs for nullable parameters and properties<http://github.com/jredville/ironruby/commit/0e82f78e9ce1e1d02229568f323f715e2a8acc16> * includes a insert-path cmdlet so that we do not rely on files on my <http://github.com/jredville/ironruby/commit/b7bda5ed2e1a00c70ea8b0046c7cbe9b62b22228> * computer<http://github.com/jredville/ironruby/commit/b7bda5ed2e1a00c70ea8b0046c7cbe9b62b22228> * Closes CP#1788<http://github.com/jredville/ironruby/commit/ad7b2463dc61cfe659f22c6a0f80c864d2846ebf> * basic specs for CP#1785<http://github.com/jredville/ironruby/commit/9a8811c74fcca5bd0240962fb09f71ee721832a4> * Closes CP#1628<http://github.com/jredville/ironruby/commit/617bad96fbc064ca2893e0c94fa1e0bfcbc45a89> * Basic tests to close CP#1679<http://github.com/jredville/ironruby/commit/f1c588953d78d5df02556201972de3f6d606131e> * Closes CP#1082<http://github.com/jredville/ironruby/commit/2ab9df852105c5dcc240026bf6b56ce703cf75e8> * Closes CP#1898<http://github.com/jredville/ironruby/commit/d131203d5b8fea1fd34cfc83fb0e098b3eb8edd3> * Closes CP#1895<http://github.com/jredville/ironruby/commit/865f3c7ac3aed5134817f933e6792deb4a29e1d8> * Closes CP#765<http://github.com/jredville/ironruby/commit/60e1eb27e92975b10af639bb70463a5dbc770c2e> * Closes CP#1995<http://github.com/jredville/ironruby/commit/cc2ef0de8f60c9f591f88c88171e48871420e484> * Specs for CP#2045<http://github.com/jredville/ironruby/commit/fb7f4f36f57589a8ed71fff028d7b5224b5d676d> * Properly compile ir, ipy and ipyw<http://github.com/jredville/ironruby/commit/089c62d2fefdc236013b4ef84fcbcbd78d6f1fe8> * deleted extra file<http://github.com/jredville/ironruby/commit/2b15fe48c486b5fffde39154dff6225842c3254e> * Regression Specs CP#2027<http://github.com/jredville/ironruby/commit/728a653df2e248ba19b4c62b2b10a50b7aa386c1> * Regression specs for CP#2190<http://github.com/jredville/ironruby/commit/edac3ef21e4068dbadb993d06b2a4b9dd3a40162> * Makes :netinterop pass again. Also adds repl.rb for a barebones debugging<http://github.com/jredville/ironruby/commit/282b4190637ffd1f2444b39fb7dfe98acd451a5a> * Regression tests for Codeplex #1927<http://github.com/jredville/ironruby/commit/de470ca0e9e153b2349714eeea50d20e7bc39969> * more binding specs<http://github.com/jredville/ironruby/commit/85ed526a3229f5e614e8fb10ddf122027d998544> * refactor generator for binding specs<http://github.com/jredville/ironruby/commit/4cfc7ce4e8c604f677e3f4ac8d765a9d26c58b9d> * specs for other misc concerns in binding<http://github.com/jredville/ironruby/commit/1426560d76e4b91f9c939e32c80e5eddb900e7b5>
_______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
