Could you add comments "TODO: thread safety" to the added fields. There are
several places that access them in thread unsafe way.
Could you also replace
return
MutableString.CreateAscii(CommandLineArguments[_currentFileIndex].ToString());
with
// TODO: convert any non-string
return
(MutableString)CommandLineArguments[_currentFileIndex];
?
Tomas
-----Original Message-----
From: Jim Deville
Sent: Wednesday, January 20, 2010 5:06 PM
To: IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: Code Review: crit_argf
tfpt review "/shelveset:crit_argf;REDMOND\jdeville"
Comment :
cleans up a few critical tags:
* re-patches mock.rb with the patch to remove respond_to last
* implements a basic implementation of ARGF, there are many holes that still
need to be filled here, but the basic idea works, and the specs are no longer
critical.
_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core
