Looks good, are the rails tests ready to go into SNAP? JD
-----Original Message----- From: Shri Borde Sent: Friday, January 22, 2010 2:26 PM To: IronRuby External Code Reviewers Cc: ironruby-core@rubyforge.org Subject: Code Review: rails tfpt review "/shelveset:rails;REDMOND\sborde" Comment : Flushes out iconv implementation. Added more specs Made String#encoding visible only in 1.9 mode Adds optional paramter to StringScanner.new The above fixes enable many more Rails tests _______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
