Utr.rb:
Please replace @disabled = 0 if @disabled == nil with @disabled ||= 0
Why are we undefining methods instead of aliasing them to noop? I'm not pulled
too strongly in either direction, but I'd like to know. If we are going to
undef, then get rid of the noop definition.
Generate_test-unit_tags.rb:
Couldn't all of ensure_single_fault_per_method_name be accomplished by:
faults.map {|e| test_method_name(e)}.uniq
Rest looks good.
JD
From: Shri Borde
Sent: Sunday, January 24, 2010 9:55 PM
To: IronRuby External Code Reviewers
Cc: [email protected]
Subject: Review: ActiveRecord tests
tfpt review /shelveset:ar;sborde
Enables active_record tests in irtests.rb. They require SQLExpress to be
installed on the machine.
_______________________________________________
Ironruby-core mailing list
[email protected]
http://rubyforge.org/mailman/listinfo/ironruby-core
