Looks good. As part of MQ, we should look deeply at the compilation based 
variables and see if they can be removed or picked up from the arguments to csc.

JD


-----Original Message-----
From: Shri Borde 
Sent: Thursday, March 11, 2010 11:36 AM
To: IronRuby External Code Reviewers
Cc: ironruby-core@rubyforge.org
Subject: FYI Code Review: config

  tfpt review "/shelveset:config;REDMOND\sborde"
  Comment  : 
  Change RbConfig::CONFIG["arch"] to "universal-dotnet2.0" (or 
"universal-dotnet4.0" on .NET 4)
  Also changed RbConfig::CONFIG["host_os"] to be based on RUBY_PLATFORM so that 
it will be mswin32 on Windows and linux on Linux.
  Removed some config values that are not present in JRuby


_______________________________________________
Ironruby-core mailing list
Ironruby-core@rubyforge.org
http://rubyforge.org/mailman/listinfo/ironruby-core

Reply via email to