Yes, this is the right process - fix it in a branch and send a pull request.
The change looks great! Merged into main and closed the bug. Thanks, Tomas -----Original Message----- From: ironruby-core-boun...@rubyforge.org [mailto:ironruby-core-boun...@rubyforge.org] On Behalf Of Nicholas Radford Sent: Saturday, May 07, 2011 1:13 AM To: ironruby-core@rubyforge.org Subject: Re: [Ironruby-core] Fwd: WorkItem Issue #6095 - "IronRuby 1.1.3 Can't count" > > Quick question guys, when pushing this to my repo on github, should I > push to a topic branch or push to master? > Well I pushed it to a topic branch, just in case you guys required changes :) As the contributing documentation says, would someone mind giving me a code review? Code can be found at https://github.com/sekhat/main/tree/bugfix/issue-6095 Cheers. _______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core _______________________________________________ Ironruby-core mailing list Ironruby-core@rubyforge.org http://rubyforge.org/mailman/listinfo/ironruby-core
