Hi Dan, No worries, sounds like we've all been busy.
I checked the email and I had attached .diff, looks like it was cut off by our mail scheduler as Mark says. I've attached it to the Jira now. I still haven't sussed Eclipse code-style template / code formatting, so that question from my email still stands. Best Regards Mike Burton Myco Systems Ltd 01753 893390 17 Criss Grove, Gerrards Cross, BUCKS, SL9 9HG Registered in England No 1832705 NOTICE: If received in error, please destroy and notify sender. Sender does not intend to waive confidentiality or privilege. Use of this email is prohibited when received in error. On 30 Jan 2011, at 11:56, Dan Haywood wrote: > Hi Mike, > Sorry not to reply sooner... > You mentioned that you'd attached a patch for review? Two things: > 1. you should instead attach to patch to the JIRA, not your email... that > keeps everything together and the contribution is attributable to you. > 2. but in any case, it seemed that you forgot to attach the patch to the > email anyway, so I can't provide any feedback. > > Could you attach your patch to the JIRA, then post here once done? > > Thanks, > Dan > > > On 24/01/2011 11:57, Mike Burton wrote: >> Hi Folks, >> >> Re my earlier comment about object associations and Dan's reply, and Jira >> issue... >> I noticed problems in the business logic hook mechanism, that would require >> changes to the noc* code templates. I then realised this would not be a >> quick fix, so I developed a Mutual Registration sample (based on the >> Customer / Car example in Dan's book) allowing dis/association from either >> end of the association. >> >> I've attached mutreg.diff here as a patch for review, specifically: >> - I've put it in<trunk>/contribs/MutualRegistration - is this the best >> place? >> - Visibility of underlying accessor methods >> - Can you think of any more test cases? >> - How can this extend to many:many relationships and their templates? >> - Impact on other artefacts (documentation, examples,...) >> >> I tried to use the Eclipse code-style template, and reformat as per Dan's >> isis-contributors-guide.pdf , but it still wraps at 80 columns and contains >> tab characters, so any help / hints here would be appreciated too. >> >> Best regards >> >> Mike Burton >> >> >>
