yuxiqian commented on code in PR #3588:
URL: https://github.com/apache/flink-cdc/pull/3588#discussion_r1739699797


##########
flink-cdc-cli/src/test/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParserTest.java:
##########
@@ -426,7 +427,9 @@ void testParsingFullDefinitionFromString() throws Exception 
{
                     Collections.emptyList(),
                     Collections.emptyList(),
                     Collections.emptyList(),
-                    
Configuration.fromMap(Collections.singletonMap("parallelism", "1")));
+                    Configuration.fromMap(
+                            Collections.singletonMap(
+                                    "local-time-zone", 
ZoneId.systemDefault().toString())));

Review Comment:
   Seems it's not necessary to pass `local-time-zone` explicitly since it will 
be accessed when constructing `PipelineDef` anyway



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to