GOODBOY008 commented on code in PR #25287:
URL: https://github.com/apache/flink/pull/25287#discussion_r1746758596
##########
flink-runtime/pom.xml:
##########
@@ -306,23 +306,10 @@ under the License.
</dependency>
<dependency>
- <!-- This must appear before powermock on the
classpath! -->
<groupId>org.mockito</groupId>
<artifactId>mockito-inline</artifactId>
<scope>test</scope>
</dependency>
-
Review Comment:
The `powermock` need to remove too.
https://github.com/apache/flink/blob/a13b7eaa28ac034806a12e0d19126ed1aaa8d920/pom.xml#L2258-L2300
##########
flink-core/src/test/java/org/apache/flink/core/fs/InitOutputPathTest.java:
##########
@@ -77,17 +77,6 @@ void testProperSynchronized() throws Exception {
runTest(false);
}
- // Line 82~ Line 191 are copied from
Review Comment:
This code block can keep it. Because this test will be rewrited without
field vaule inject.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
