AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1756479346
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/committables/CheckpointCommittableManagerImpl.java:
##########
@@ -72,18 +73,24 @@ Collection<SubtaskCommittableManager<CommT>>
getSubtaskCommittableManagers() {
return subtasksCommittableManagers.values();
}
- void upsertSummary(CommittableSummary<CommT> summary) {
+ void addSummary(CommittableSummary<CommT> summary) {
Review Comment:
Changed the name as upsert imples that we always merge but we really just
want to do this for EOI now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
