Zakelly commented on code in PR #25310:
URL: https://github.com/apache/flink/pull/25310#discussion_r1758146251
##########
flink-state-backends/flink-statebackend-forst/src/main/java/org/apache/flink/state/forst/fs/ForStFlinkFileSystem.java:
##########
@@ -101,6 +156,13 @@ public boolean rename(Path src, Path dst) throws
IOException {
// The rename is not atomic for ForSt. Some FileSystems e.g. HDFS, OSS
does not allow a
// renaming if the target already exists. So, we delete the target
before attempting the
// rename.
+
+ if (localFileFilter.apply(src.getName())) {
+ Path localSrc = tryBuildLocalPath(src).f1;
+ Path localDst = tryBuildLocalPath(dst).f1;
+ return localFS.rename(localSrc, localDst);
Review Comment:
if this is directory, the remote path should also be renamed. I'd suggest
check the filestatus first
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
