AHeise commented on code in PR #25292:
URL: https://github.com/apache/flink/pull/25292#discussion_r1759079752
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/operators/sink/CommitterOperator.java:
##########
@@ -208,8 +209,8 @@ public void
processElement(StreamRecord<CommittableMessage<CommT>> element) thro
// in case of unaligned checkpoint, we may receive
notifyCheckpointComplete before the
// committables
- OptionalLong checkpointId = element.getValue().getCheckpointId();
- if (checkpointId.isPresent() && checkpointId.getAsLong() <=
lastCompletedCheckpointId) {
+ long checkpointId = element.getValue().getCheckpointIdOrEOI();
+ if (checkpointId <= lastCompletedCheckpointId) {
Review Comment:
Yes, we mean the same thing. For EOI committables, this check will always
yield false. Even without the special case on EOI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
