davidradl commented on code in PR #25290:
URL: https://github.com/apache/flink/pull/25290#discussion_r1760819433
##########
docs/content/docs/deployment/advanced/logging.md:
##########
@@ -67,6 +67,8 @@ The Flink distribution ships with the following log4j
properties files in the `c
Log4j periodically scans this file for changes and adjusts the logging
behavior if necessary.
By default this check happens every 30 seconds and is controlled by the
`monitorInterval` setting in the Log4j properties files.
+You can configure the default logging level using the [`env.log.level`
configuration]({{< ref "docs/deployment/config">}}#jvm-and-logging-options).
Review Comment:
The sentence at the top says "Log4j 2 is controlled using property files."
This is not correct - we add and also the configuration.
Maybe have 2 subsections one for the properties and one for the
configuration. I suggest documenting the other 2 log related configurations
options also here.
I think is is confusing using the word default - as this setting has a
default. I think it would be easier to parse using words like : you can
configure the logging level max and dir in the configuration . The logging
level specified in the configuration can be overridden in the log4j property
files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
