kumar-mallikarjuna commented on code in PR #25027:
URL: https://github.com/apache/flink/pull/25027#discussion_r1771279162
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/OnMainThreadJobManagerRunnerRegistry.java:
##########
@@ -84,9 +84,10 @@ public Collection<JobManagerRunner> getJobManagerRunners() {
}
@Override
- public CompletableFuture<Void> localCleanupAsync(JobID jobId, Executor
executor) {
+ public CompletableFuture<Void> localCleanupAsync(
+ JobID jobId, Executor cleanupExecutor, Executor executor) {
Review Comment:
> I'm wondering whether we should even use ComponentMainThreadExecutor as a
type for the main thread executor to make things clear.
I tried this but not sure why but the tests got stuck.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
