X-czh commented on code in PR #25797:
URL: https://github.com/apache/flink/pull/25797#discussion_r1903292910
##########
flink-core/src/main/java/org/apache/flink/api/common/serialization/SerializerConfigImpl.java:
##########
@@ -356,6 +356,9 @@ public void configure(ReadableConfig configuration,
ClassLoader classLoader) {
configuration
.getOptional(PipelineOptions.FORCE_KRYO_AVRO)
.ifPresent(this::setForceKryoAvro);
+ configuration
+ .getOptional(PipelineOptions.BUILT_IN_COLLECTION_TYPES)
+ .ifPresent(TypeExtractor::setBuiltInCollectionTypesEnabled);
Review Comment:
You are right, the TypeExtractor is a static util class. However, it is only
used when compiling the job, which is done on the client side for Session mode,
where only one job is executed at a time. Since migrating TypeExtractor to an
instance class is not an easy job, we might better implement it in this way
first, and try migrating it to an instance class for proper parameterization
later. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
