leonardBang commented on code in PR #3824:
URL: https://github.com/apache/flink-cdc/pull/3824#discussion_r1914356530
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/PaimonMetadataApplierTest.java:
##########
@@ -137,6 +140,12 @@ public void testApplySchemaChange(String metastore)
Assertions.assertEquals(
tableSchema,
catalog.getTable(Identifier.fromString("test.table1")).rowType());
+ Assertions.assertEquals(
+ "col3DefValue",
+ catalog.getTable(Identifier.fromString("test.table1"))
+ .options()
+ .get("fields.col3.default-value"));
+
Map<String, String> nameMapping = new HashMap<>();
nameMapping.put("col2", "newcol2");
nameMapping.put("col3", "newcol3");
Review Comment:
Thanks @lvyanquan for the clarification, I guessed Paimon's underlying
implementation, just comment it's a little wired
##########
flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/PaimonMetadataApplierTest.java:
##########
@@ -137,6 +140,12 @@ public void testApplySchemaChange(String metastore)
Assertions.assertEquals(
tableSchema,
catalog.getTable(Identifier.fromString("test.table1")).rowType());
+ Assertions.assertEquals(
+ "col3DefValue",
+ catalog.getTable(Identifier.fromString("test.table1"))
+ .options()
+ .get("fields.col3.default-value"));
+
Map<String, String> nameMapping = new HashMap<>();
nameMapping.put("col2", "newcol2");
nameMapping.put("col3", "newcol3");
Review Comment:
Thanks @lvyanquan for the clarification, I guessed Paimon's underlying
implementation, just comment it's a little wired
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
