martongreber commented on code in PR #8:
URL:
https://github.com/apache/flink-connector-kudu/pull/8#discussion_r1975011086
##########
flink-connector-kudu/src/main/java/org/apache/flink/connector/kudu/connector/converter/RowResultRowConverter.java:
##########
@@ -31,6 +32,9 @@ public Row convert(RowResult row) {
Schema schema = row.getColumnProjection();
Row values = new Row(schema.getColumnCount());
+ if (row.hasIsDeleted() && row.isDeleted()) {
+ values.setKind(RowKind.DELETE);
+ }
Review Comment:
I assume this was not needed in the past, to differentiate whether a record
is a delete record.
Kudu has the above api to provide this info. We would like to use it later
down the road. However it is true that its not core for the current PR, so
removed it. Will create a followup PR later for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
