twalthr commented on code in PR #26247:
URL: https://github.com/apache/flink/pull/26247#discussion_r1989176011
##########
flink-python/pyflink/table/module.py:
##########
@@ -34,6 +37,7 @@ def __init__(self, j_module):
self._j_module = j_module
+@PublicEvolving()
class HiveModule(Module):
Review Comment:
Not sure why this is here. The Hive module got factored out of the Flink
core repository? Maybe a followup issue to remove it? Maybe don't annotate it?
##########
flink-python/pyflink/table/table.py:
##########
@@ -959,14 +962,12 @@ def to_pandas(self):
import pandas as pd
return pd.DataFrame.from_records([],
columns=self.get_schema().get_field_names())
+ @Deprecated(since="2.1.0", detail=":func:`Table.get_resolved_schema`
instead.")
Review Comment:
```suggestion
@Deprecated(since="2.1.0", detail="Use :func:`Table.get_resolved_schema`
instead.")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
