RocMarshal commented on code in PR #26308:
URL: https://github.com/apache/flink/pull/26308#discussion_r2000088209
##########
flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java:
##########
@@ -708,6 +708,11 @@ public class TaskManagerOptions {
"The %s mode tries to
spread out the slots evenly across all available %s.",
code(TaskManagerLoadBalanceMode.SLOTS.name()),
code("TaskManagers")),
+ text(
+ "The %s mode tries to
allocate slots on minimum number of available resources.",
+ code(
+
TaskManagerLoadBalanceMode.MIN_RESOURCES
+ .name())),
Review Comment:
Hi, @vahmed-hamdy Thanks for the contribution !
LGTM overall , only a minor comments.
What about
```suggestion
"The %s mode tries to
allocate slots on minimum number of available %s.",
code(
TaskManagerLoadBalanceMode.MIN_RESOURCES
.name()),
code("TaskManagers")),
```
The description of `TaskManager` sounds intuitive and easy to understand.
WDYT ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
