FranMorilloAWS commented on code in PR #191:
URL:
https://github.com/apache/flink-connector-aws/pull/191#discussion_r2034866646
##########
flink-catalog-aws-glue/src/main/java/com/amazonaws/services/msf/GlueCatalogFactory.java:
##########
@@ -0,0 +1,66 @@
+package com.amazonaws.services.msf;
+
+import org.apache.flink.configuration.ConfigOption;
+import org.apache.flink.configuration.ConfigOptions;
+import org.apache.flink.configuration.ReadableConfig;
+import org.apache.flink.table.catalog.Catalog;
+import org.apache.flink.table.catalog.exceptions.CatalogException;
+import org.apache.flink.table.factories.CatalogFactory;
+import software.amazon.awssdk.regions.Region;
+import software.amazon.awssdk.services.glue.GlueClient;
+
+import java.util.HashSet;
+import java.util.Map;
+import java.util.Set;
+
+public class GlueCatalogFactory implements CatalogFactory {
+
+ // Define configuration options that users must provide
+ public static final ConfigOption<String> REGION =
+ ConfigOptions.key("region")
Review Comment:
They don't to that distinction for the other Catalogs
-
https://nightlies.apache.org/flink/flink-docs-release-1.20/docs/connectors/table/jdbc/#jdbc-catalog
-
As they would need to put as Catalog type: glue, not sure if it makes sense
to be repetitive and add glue to all configs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
