dawidwys commented on code in PR #26436:
URL: https://github.com/apache/flink/pull/26436#discussion_r2036846898
##########
flink-table/flink-table-runtime/src/test/java/org/apache/flink/table/data/DataStructureConvertersTest.java:
##########
@@ -355,7 +355,62 @@ static List<TestSpec> testData() {
TestSpec.forDataType(
DataTypes.STRUCTURED(GenericPojo.class,
FIELD("value", DATE())))
.convertedTo(
- GenericPojo.class, new
GenericPojo<>(LocalDate.ofEpochDay(123))));
+ GenericPojo.class, new
GenericPojo<>(LocalDate.ofEpochDay(123))),
+
+ // partial delete messages
+ TestSpec.forDataType(
+ DataTypes.ROW(
+ DataTypes.FIELD("f0",
DataTypes.TINYINT().notNull()),
+ DataTypes.FIELD("f1",
DataTypes.SMALLINT().notNull()),
+ DataTypes.FIELD("f2",
DataTypes.INT().notNull()),
+ DataTypes.FIELD("f3",
DataTypes.BIGINT().notNull()),
+ DataTypes.FIELD("f4",
DataTypes.DOUBLE().notNull()),
+ DataTypes.FIELD("f5",
DataTypes.FLOAT().notNull()),
+ DataTypes.FIELD("f6",
DataTypes.DATE().notNull()),
+ DataTypes.FIELD("f7",
DataTypes.BINARY(12).notNull()),
+ DataTypes.FIELD("f8",
DataTypes.VARBINARY(12).notNull()),
+ DataTypes.FIELD("f9",
DataTypes.CHAR(12).notNull()),
+ DataTypes.FIELD("f10",
DataTypes.VARCHAR(12).notNull()),
+ DataTypes.FIELD("f11",
DataTypes.BOOLEAN().notNull()),
+ DataTypes.FIELD("f12",
DataTypes.TIME().notNull()),
+ DataTypes.FIELD("f13",
DataTypes.TIMESTAMP().notNull()),
+ DataTypes.FIELD("f14",
DataTypes.TIMESTAMP_LTZ().notNull()),
+ DataTypes.FIELD("f15",
DataTypes.DECIMAL(10, 2).notNull()),
+ DataTypes.FIELD(
+ "f16",
+ DataTypes.MAP(DataTypes.INT(),
DataTypes.STRING())
+ .notNull()),
+ DataTypes.FIELD(
+ "f17",
DataTypes.ARRAY(DataTypes.INT()).notNull()),
+ DataTypes.FIELD(
+ "f18",
DataTypes.ARRAY(DataTypes.INT()).notNull()),
+ DataTypes.FIELD(
+ "f19",
+
DataTypes.MULTISET(DataTypes.INT()).notNull())))
+ .convertedTo(
+ Row.class,
+ Row.ofKind(
+ RowKind.DELETE,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ null,
+ new Integer[] {null, null},
Review Comment:
I should update the element type to be not null, though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
