leonardBang commented on code in PR #3887:
URL: https://github.com/apache/flink-cdc/pull/3887#discussion_r2052201271
##########
flink-cdc-cli/src/main/java/org/apache/flink/cdc/cli/parser/YamlPipelineDefinitionParser.java:
##########
@@ -188,7 +189,14 @@ private SourceDef toSourceDef(JsonNode sourceNode) {
// "name" field is optional
String name = sourceMap.remove(NAME_KEY);
- return new SourceDef(type, name, Configuration.fromMap(sourceMap));
+ // "parallelism" field is optional
+ Integer parallelismValue = null;
Review Comment:
Could we use `pipeline.parallelism`'s valued as default parallelism instead
of an error-prone null value? then we can use `int` type and do not need to
use `@Nullable ` annotation in related methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
