cushon commented on code in PR #26491:
URL: https://github.com/apache/flink/pull/26491#discussion_r2056476036
##########
flink-clients/src/main/java/org/apache/flink/client/program/PackagedProgram.java:
##########
@@ -218,12 +217,7 @@ public String getDescription() throws
ProgramInvocationException {
* local execution by default.
*/
public void invokeInteractiveModeForExecution() throws
ProgramInvocationException {
- FlinkSecurityManager.monitorUserSystemExitForCurrentThread();
- try {
- callMainMethod(mainClass, args);
- } finally {
- FlinkSecurityManager.unmonitorUserSystemExitForCurrentThread();
- }
+ callMainMethod(mainClass, args);
Review Comment:
The JDK Security Manager APIs were [deprecated in JDK
17](https://openjdk.org/jeps/411) which was released in 2021, and it has been
[removed in JDK 24](https://openjdk.org/jeps/486). This code doesn't build with
DJK 24 and newer.
I'm not sure there's a great way to keep this functionality around in a
deprecated state and support newer JDKs. It might be possible to do something
with multi-release jars.
I guess another option would be to mark `FlinkSecurityManager` as
deprecated, and then remove it in a later release, and wait until that later
release for Flink to support JDK 24 and newer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
