davidradl commented on code in PR #26501:
URL: https://github.com/apache/flink/pull/26501#discussion_r2058036435
##########
docs/data/sql_connectors.yml:
##########
@@ -156,15 +156,15 @@ kafka:
versions:
- version: universal
maven: flink-connector-kafka
- sql_url:
https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka/$version/flink-sql-connector-kafka-$version.jar
+ sql_url:
https://repo.maven.apache.org/maven2/org/apache/flink/flink-sql-connector-kafka/4.0.0-2.0/flink-sql-connector-kafka-4.0.0-2.0.jar
Review Comment:
I am wondering why need to hard code the version.
I assume prior to this change the version was coming through as 3.4.0-1.20
or was this never working?
If we have to hard code - it would make sense to introduce a new variable ,
maybe constructed from $version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
