morazow commented on PR #26514:
URL: https://github.com/apache/flink/pull/26514#issuecomment-2835669773

   Thanks @davidradl, addressed your findings, please have another look 🤝 
   
   > the filtered pushed down joins cause the Volcano planner to uniquely 
identify each look up join.
   
   Yes, but based on the getDigests method, which results in a string like 
below:
   
   ```
   LookupJoin(table=[default_catalog.default_database.dim], 
joinType=[InnerJoin], lookup=[id=id], select=[id, name, txn_time, id], 
upsertKey=[[0]])
   ```
   
   Here we have the table name, but no information on the pushed down filter 
conditions. For this issue to happen, the lookup table's should be same (since 
it is in the digest), so we cannot test if one part supports and other part 
doesn't test case. 
   
   Additionally, if the source doesn't support the filter pushdown it will be 
represented in the digest with the `where` keyword. This will not also 
reproduce the bug because the digests are different.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to