phamvinh1712 commented on code in PR #4004:
URL: https://github.com/apache/flink-cdc/pull/4004#discussion_r2072691369
##########
flink-cdc-connect/flink-cdc-source-connectors/flink-connector-postgres-cdc/src/main/java/org/apache/flink/cdc/connectors/postgres/source/utils/TableDiscoveryUtils.java:
##########
@@ -38,7 +38,8 @@ public static List<TableId> listTables(
throws SQLException {
Set<TableId> allTableIds =
- jdbc.readTableNames(database, null, null, new String[]
{"TABLE"});
Review Comment:
> Theres is also another concern. If user use regex expression as table
name, both parent table and subtable will be captured. **Then snapshot data
will be read twice.**
>
> Thus, a option can also tell user that. If they enable partition table,
they should pay attention to it.
do you have any suggestion for this? should we add a section on flink-cdc
doc for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
