AHeise commented on code in PR #26601:
URL: https://github.com/apache/flink/pull/26601#discussion_r2111083060
##########
flink-table/flink-table-planner/src/main/scala/org/apache/flink/table/planner/delegation/PlannerBase.scala:
##########
@@ -462,11 +462,14 @@ abstract class PlannerBase(
}
case regularTable: CatalogTable =>
- val resolvedTable =
contextResolvedTable.getResolvedTable[ResolvedCatalogTable]
- val tableToFind = if (dynamicOptions.nonEmpty) {
- resolvedTable.copy(FlinkHints.mergeTableOptions(dynamicOptions,
resolvedTable.getOptions))
Review Comment:
The extra val allows us to use val in scala rather than vars for the result.
I can change to var but I found the code base uses mostly vals but I'm new to
the planner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
