snuyanzin commented on code in PR #26638:
URL: https://github.com/apache/flink/pull/26638#discussion_r2132125616
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/types/LogicalTypesTest.java:
##########
@@ -797,42 +831,46 @@ private StructuredType createHumanType(boolean
useDifferentImplementation) {
useDifferentImplementation ? SpecialHuman.class :
Human.class)
.attributes(
Collections.singletonList(
- new StructuredType.StructuredAttribute(
- "name", UDT_NAME_TYPE,
"Description.")))
+ new StructuredAttribute("name", UDT_NAME_TYPE,
"Description.")))
.description("Human type desc.")
.setFinal(false)
.setInstantiable(false)
.build();
}
- private StructuredType createUserType(boolean isRegistered, boolean
isFinal) {
+ private StructuredType createUserType(
Review Comment:
should it be a builder with more selfexplainable methods?
Asking since now `createUserType(false, false, false)` without looking into
implementation it is hard to say what all those `false` mean
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
