mxm commented on code in PR #26640:
URL: https://github.com/apache/flink/pull/26640#discussion_r2132408298
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBOptions.java:
##########
@@ -91,6 +91,15 @@ public class RocksDBOptions {
+ CLUSTER_IO_EXECUTOR_POOL_SIZE.key()
+ ")");
+ /** The number of millisecond for RocksDBStateBackend checkpoint file
upload jitter. */
+ @Documentation.Section(Documentation.Sections.EXPERT_ROCKSDB)
+ public static final ConfigOption<Long> CHECKPOINT_UPLOAD_JITTER =
Review Comment:
Please use Duration:
```suggestion
public static final ConfigOption<Duration> CHECKPOINT_UPLOAD_JITTER =
```
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBStateUploader.java:
##########
@@ -43,21 +43,26 @@
import java.util.List;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.ExecutionException;
+import java.util.concurrent.ThreadLocalRandom;
Review Comment:
I'm curious, why ThreadLocalRandom? Why not `Random`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
