ChenYi015 commented on PR #985:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/985#issuecomment-2949887793
One can verify that there is no changes to the templated manifests after
this reorganization:
```bash
$ # main branch
$ git checkout main
$ # helm template with default values
$ helm template flink-operator helm/flink-kubernetes-operator | yq eval-all
'[.] | map(select(length > 0)) |
sort_by(.kind,.metadata.name,.metadata.namespace) | .[] | splitDoc' >
before-1.yaml
$ # helm template with multi-namespaces values
$ helm template flink-operator helm/flink-kubernetes-operator --set
'watchNamespaces={ns1,ns2,ns3}' | yq eval-all '[.] | map(select(length > 0)) |
sort_by(.kind,.metadata.name,.metadata.namespace) | .[] | splitDoc' >
before-2.yaml
$ # this branch
$ git checkout helm/reorganize-templates
$ # helm template with default values
$ helm template flink-operator helm/flink-kubernetes-operator | yq eval-all
'[.] | map(select(length > 0)) |
sort_by(.kind,.metadata.name,.metadata.namespace) | .[] | splitDoc' >
after-1.yaml
$ # helm template with multi-namespaces values
$ helm template flink-operator helm/flink-kubernetes-operator --set
'watchNamespaces={ns1,ns2,ns3}' | yq eval-all '[.] | map(select(length > 0)) |
sort_by(.kind,.metadata.name,.metadata.namespace) | .[] | splitDoc' >
after-2.yaml
$ # diff
$ diff before-1.yaml after-1.yaml
1c1
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source: flink-kubernetes-operator/templates/cert-manager/certificate.yaml
23c23
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/cluster_role.yaml
139c139
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source:
flink-kubernetes-operator/templates/rbac/cluster_role_binding.yaml
159c159
< # Source: flink-kubernetes-operator/templates/flink-operator.yaml
---
> # Source: flink-kubernetes-operator/templates/controller/configmap.yaml
418c418
< # Source: flink-kubernetes-operator/templates/flink-operator.yaml
---
> # Source: flink-kubernetes-operator/templates/controller/deployment.yaml
558c558
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source: flink-kubernetes-operator/templates/cert-manager/issuer.yaml
567c567
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source:
flink-kubernetes-operator/templates/webhook/mutating_webhook_configuration.yaml
595c595
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/role.yaml
636c636
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/role_binding.yaml
658c658
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source: flink-kubernetes-operator/templates/webhook/secret.yaml
667a668
> # Source: flink-kubernetes-operator/templates/webhook/service.yaml
680c681
< # Source: flink-kubernetes-operator/templates/serviceaccount.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/service_account.yaml
694c695
< # Source: flink-kubernetes-operator/templates/serviceaccount.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/service_account.yaml
706c707
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source:
flink-kubernetes-operator/templates/webhook/validating_webhook_configuration.yaml
$ diff before-2.yaml after-2.yaml
1c1
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source: flink-kubernetes-operator/templates/cert-manager/certificate.yaml
23c23
< # Source: flink-kubernetes-operator/templates/flink-operator.yaml
---
> # Source: flink-kubernetes-operator/templates/controller/configmap.yaml
284c284
< # Source: flink-kubernetes-operator/templates/flink-operator.yaml
---
> # Source: flink-kubernetes-operator/templates/controller/deployment.yaml
424c424
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source: flink-kubernetes-operator/templates/cert-manager/issuer.yaml
433c433
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source:
flink-kubernetes-operator/templates/webhook/mutating_webhook_configuration.yaml
466c466
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/role.yaml
507c507
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/role.yaml
548c548
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/role.yaml
589c589
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/role.yaml
613a614
> # Source: flink-kubernetes-operator/templates/rbac/role.yaml
729c730
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/role.yaml
845c846
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/role.yaml
961c962
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/role_binding.yaml
981c982
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/role_binding.yaml
1001c1002
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/role_binding.yaml
1021c1022
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/role_binding.yaml
1041c1042
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/role_binding.yaml
1063c1064
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/role_binding.yaml
1085c1086
< # Source: flink-kubernetes-operator/templates/rbac.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/role_binding.yaml
1107c1108
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source: flink-kubernetes-operator/templates/webhook/secret.yaml
1116a1118
> # Source: flink-kubernetes-operator/templates/webhook/service.yaml
1129c1131
< # Source: flink-kubernetes-operator/templates/serviceaccount.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/service_account.yaml
1143c1145
< # Source: flink-kubernetes-operator/templates/serviceaccount.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/service_account.yaml
1157c1159
< # Source: flink-kubernetes-operator/templates/serviceaccount.yaml
---
> # Source: flink-kubernetes-operator/templates/flink/service_account.yaml
1171c1173
< # Source: flink-kubernetes-operator/templates/serviceaccount.yaml
---
> # Source: flink-kubernetes-operator/templates/rbac/service_account.yaml
1183c1185
< # Source: flink-kubernetes-operator/templates/webhook.yaml
---
> # Source:
flink-kubernetes-operator/templates/webhook/validating_webhook_configuration.yaml
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
