davidradl commented on code in PR #26651:
URL: https://github.com/apache/flink/pull/26651#discussion_r2137619890
##########
flink-runtime/src/main/java/org/apache/flink/runtime/state/heap/HeapKeyedStateBackend.java:
##########
@@ -259,17 +261,8 @@ private <N, V> StateTable<K, N, V> tryRegisterStateTable(
+ ") must not be incompatible with the old
state serializer ("
+ previousStateSerializer
+ ").");
- }
-
- // HeapKeyedStateBackend doesn't support ttl state migration
currently.
- if (TtlAwareSerializer.needTtlStateMigration(
- previousStateSerializer, newStateSerializer)) {
- throw new StateMigrationException(
- "For heap backends, the new state serializer ("
- + newStateSerializer
- + ") must not need ttl state migration with
the old state serializer ("
- + previousStateSerializer
- + ").");
+ } else if (stateCompatibility.isCompatibleAfterMigration()) {
+ migrateStateValues(stateDesc, previousStateSerializer,
newStateSerializer);
Review Comment:
what happens if the state is not compatible, I suggest we should at least
log for that case - or should there be an error in that case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
