nateab commented on code in PR #26666:
URL: https://github.com/apache/flink/pull/26666#discussion_r2150975691
##########
flink-core/src/main/java/org/apache/flink/configuration/CheckpointingOptions.java:
##########
@@ -576,8 +576,8 @@ public class CheckpointingOptions {
.build());
@Experimental
- public static final ConfigOption<Boolean>
ENABLE_UNALIGNED_INTERRUPTIBLE_TIMERS =
-
ConfigOptions.key("execution.checkpointing.unaligned.interruptible-timers.enabled")
+ public static final ConfigOption<Boolean>
ENABLE_UNALIGNED_SPLITTABLE_TIMERS =
Review Comment:
We have an internal fork of Flink and I noticed that we only used the
splittable config instead of the interruptible config. I figured that maybe
something went wrong when @pnowojski open sourced this feature. Piotr can you
confirm whether we should be using `splittable` or `interruptible` here,
because right now they are intermixed like on this line
https://github.com/apache/flink/pull/26666/files#diff-35fa4795524db4fca98cd404f3184bf9ec2a903d673f49074a1ab970733aa0eaL1261-L1262
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
