twalthr commented on code in PR #26683:
URL: https://github.com/apache/flink/pull/26683#discussion_r2152075536
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java:
##########
@@ -116,7 +116,7 @@ protected ExecNodeBase(
String description) {
this.context = checkNotNull(context).withId(id);
this.persistedConfig = persistedConfig == null ? new Configuration() :
persistedConfig;
- this.inputProperties = checkNotNull(inputProperties);
+ this.inputProperties = inputProperties == null ? List.of() :
inputProperties;
Review Comment:
Annotate the arg if null is possible
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/ExecNodeBase.java:
##########
@@ -116,7 +116,7 @@ protected ExecNodeBase(
String description) {
this.context = checkNotNull(context).withId(id);
this.persistedConfig = persistedConfig == null ? new Configuration() :
persistedConfig;
- this.inputProperties = checkNotNull(inputProperties);
+ this.inputProperties = inputProperties == null ? List.of() :
inputProperties;
Review Comment:
when is null possible? add a comment for this case
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/exec/serde/CompiledPlanSerdeUtil.java:
##########
@@ -278,6 +331,19 @@ static <T> Optional<T> deserializeOptionalField(
return Optional.empty();
}
+ static <T> T deserializeFieldOrNull(
Review Comment:
```suggestion
static <T> @Nullable T deserializeFieldOrNull(
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
