gustavodemorais commented on code in PR #26687:
URL: https://github.com/apache/flink/pull/26687#discussion_r2153347809
##########
flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/runtime/operators/join/stream/keyselector/AttributeBasedJoinKeyExtractor.java:
##########
@@ -417,14 +417,19 @@ private boolean
isCommonConceptualAttributeSet(Set<AttributeRef> eqSet) {
private void processCommonAttributes(List<Set<AttributeRef>>
commonConceptualAttributeSets) {
for (int currentInputId = 0; currentInputId < inputTypes.size();
currentInputId++) {
- List<AttributeRef> commonAttrsForThisInput =
+ final List<AttributeRef> commonAttrsForThisInput =
findCommonAttributesForInput(currentInputId,
commonConceptualAttributeSets);
if (commonAttrsForThisInput.isEmpty()) {
+ // This indicates that there is no common join key among all
inputs.
+ // In this case, we cannot use a multi-join, so throw an
exception.
throw new IllegalStateException(
"No common attributes found for inputId "
+ currentInputId
- + ". This indicates a misconfiguration in
joinAttributeMap.");
+ + ". This indicates a misconfiguration in
joinAttributeMap,"
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
