[
https://issues.apache.org/jira/browse/FLINK-37889?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17981679#comment-17981679
]
Stepan Stepanishchev commented on FLINK-37889:
----------------------------------------------
Hey [~gustavodemorais] , I actually dealt with commonJoinKey check and creating
multiple multijoins if theres no commonJoinKey there
[https://github.com/apache/flink/pull/26689.] Do you want me to move this MR
onto FLINK-37890? I can add checks for commonJoinKey, creating multiple joins
when no commonJoinKeys and logic to handle right joins in 37890 after
[https://github.com/apache/flink/pull/26687|https://github.com/apache/flink/pull/26687.]
will be merged. Let me know what to do and I'll adapt. Thank you.
Also if you want to communicate faster and keep in touch with what we both
doing rn, feel free to text me in telegram @geekysteve.
> Add new FlinkJoinToFlinkMultiJoinRule rule
> ------------------------------------------
>
> Key: FLINK-37889
> URL: https://issues.apache.org/jira/browse/FLINK-37889
> Project: Flink
> Issue Type: Sub-task
> Reporter: Gustavo de Morais
> Priority: Major
>
> The current FlinkJoinToMultiJoinRule is implemented and only used for join
> reordering. We can use it as a base but we need a new set of optimizer rules
> for the multi way join operator. This ticket covers:
> * Add FlinkLogicalMultiJoin with all parameters we need to create it
> ** There are some parameters that calcite's MultiJoin does not contain as we
> require it. For example: we only have outerJoinConditions and we actually
> need all join conditions for each input level, including inner joins.
> Related:
> * Add right join to left join rule - our operator only works with left joins
> * Check if the join chain respects the multi join common key restrictions
> ** If not, create one multi join for each group of joins that respect. That
> means 9 chained joins, 3 have one common key and 6 have another will generate
> two chained multi joins.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
