gustavodemorais commented on PR #26689: URL: https://github.com/apache/flink/pull/26689#issuecomment-2984474615
> Say we have A JOIN B JOIN C JOIN D and A, B, C have commonJoinKey but D doesnt. My code will give MJ(A, B, C) JOIN D. But what we want is actually MJ(MJ(A, B, C), D). Am I correct? Exactly 👍 Or in a more realistic scenario, if we have A JOIN B JOIN C JOIN D JOIN E, we could have MJ(MJ(A, B, C), D, E). Or even more concatenated multi joins. > What do you mean by covering right joins? The rule will be applied only for inner and left joins: I saw you had some tests with right joins. I didn't think it through for project and join nodes playing with the RightJoinToLeftJoin rule. I _think_ that the multijoin check (right instanceof FlinkMultiJoinNode) can be dropped? > I'll start today with 37890 and hope to drop PR by tomorrow. I will keep you informated. If you're not 100% done you can also open a draft PR so I can collaborate or else I'll have to start my own. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
