twalthr commented on code in PR #26703:
URL: https://github.com/apache/flink/pull/26703#discussion_r2157315749
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/calcite/RelTimeIndicatorConverter.java:
##########
@@ -521,6 +520,57 @@ private RelNode
visitWindowTableAggregate(FlinkLogicalWindowTableAggregate table
tableAgg.getNamedProperties());
}
+ private RelNode visitMultiJoin(FlinkLogicalMultiJoin multiJoin) {
+ // visit and materialize children
+ final List<RelNode> newInputs =
+ multiJoin.getInputs().stream()
+ .map(input -> input.accept(this))
+ .map(this::materializeTimeIndicators)
+ .collect(Collectors.toList());
+
+ final List<RelDataTypeField> allFields =
+ newInputs.stream()
+ .flatMap(input ->
input.getRowType().getFieldList().stream())
+ .collect(Collectors.toList());
+
+ final RexShuttle shuttle =
+ new RexShuttle() {
Review Comment:
actually, I think this shuttle is not required. RexTimeIndicatorMaterializer
should be able to do the job, no?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
