fsk119 commented on code in PR #26694:
URL: https://github.com/apache/flink/pull/26694#discussion_r2158353076


##########
docs/content/docs/dev/table/sql/queries/model-inference.md:
##########
@@ -0,0 +1,134 @@
+---
+title: "Model Inference"
+weight: 7
+type: docs
+---
+<!--
+Licensed to the Apache Software Foundation (ASF) under one
+or more contributor license agreements.  See the NOTICE file
+distributed with this work for additional information
+regarding copyright ownership.  The ASF licenses this file
+to you under the Apache License, Version 2.0 (the
+"License"); you may not use this file except in compliance
+with the License.  You may obtain a copy of the License at
+
+  http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing,
+software distributed under the License is distributed on an
+"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+KIND, either express or implied.  See the License for the
+specific language governing permissions and limitations
+under the License.
+-->
+
+# Model Inference
+
+{{< label Streaming >}}
+
+Flink SQL provides the `ML_PREDICT` table-valued function (TVF) to perform 
model inference in SQL queries. This function allows you to apply machine 
learning models to your data streams directly in SQL.
+See [Model Creation]({{< ref "docs/dev/table/sql/create#create-model" >}}) 
about how to create a model.
+
+## ML_PREDICT Function
+
+The `ML_PREDICT` function takes a table input, applies a model to it, and 
returns a new table with the model's predictions. The function offers support 
for synchronous/asynchronous inference modes when the underlying model permits 
both.
+
+### Syntax
+
+```sql
+SELECT * FROM
+ML_PREDICT(
+  TABLE input_table,
+  MODEL model_name,
+  DESCRIPTOR(feature_columns),
+  [CONFIG => MAP['key', 'value']]

Review Comment:
   It's better use
   
   ```
   SELECT * FROM
   ML_PREDICT(
   TABLE input_table,
     MODEL model_name,
     DESCRIPTOR(feature_columns),
   [MAP['key', 'value']]
   ```
   
   Because flink only supports:
   1. all arguments use named argument
   2. all arguments don't use named argument
   
   We get an error for the following statement:
   
   ```
   SELECT id, len, z
   FROM ML_PREDICT(TABLE nullable_src, MODEL m2, DESCRIPTOR(`id`, `len`), 
CONFIG => MAP['async','false']) 
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to