snuyanzin commented on code in PR #26707:
URL: https://github.com/apache/flink/pull/26707#discussion_r2160508587
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/rules/logical/JoinToMultiJoinRule.java:
##########
@@ -345,41 +327,25 @@ private List<RelNode> combineInputs(
* The join type is also set.
*
* @param joinRel join rel
- * @param combinedInputs the combined inputs to the join
* @param left left child of the joinrel
- * @param right right child of the joinrel
* @param joinSpecs the list where the join types and conditions will be
copied
*/
private void combineJoinInfo(
- Join joinRel,
- List<RelNode> combinedInputs,
- RelNode left,
- RelNode right,
- List<Pair<JoinRelType, RexNode>> joinSpecs,
- List<Boolean> inputNullGenFieldList) {
Review Comment:
no idea why do we need so many args if finally half of them are not used
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
