codenohup commented on code in PR #37:
URL: https://github.com/apache/flink-agents/pull/37#discussion_r2163592878
##########
runtime/pom.xml:
##########
@@ -47,6 +47,23 @@ under the License.
<version>${flink.version}</version>
<scope>provided</scope>
</dependency>
+ <dependency>
+ <groupId>com.alibaba</groupId>
+ <artifactId>pemja</artifactId>
+ <version>0.6.0</version>
Review Comment:
Should the pemja version be specified in the properties section?
##########
runtime/src/main/java/org/apache/flink/agents/runtime/env/PythonEnvironmentManager.java:
##########
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.flink.agents.runtime.env;
+
+import org.apache.flink.api.common.JobID;
+import org.apache.flink.core.fs.Path;
+import org.apache.flink.python.env.AbstractPythonEnvironmentManager;
+import org.apache.flink.python.env.PythonDependencyInfo;
+import org.apache.flink.python.env.PythonEnvironment;
+import pemja.core.PythonInterpreterConfig;
+
+import java.util.HashMap;
+import java.util.Map;
+
+import static
org.apache.flink.python.util.PythonDependencyUtils.PARAM_DELIMITER;
+
+/**
+ * The base class of python environment manager which is used to create the
PythonEnvironment
+ * object. It's used to run python functions in embedded Python environment.
Review Comment:
Could we add test cases that verify and explain how to execute the Python
function with `PythonEnvironmentManager`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
