GreatEugenius commented on code in PR #43:
URL: https://github.com/apache/flink-agents/pull/43#discussion_r2174301665
##########
python/flink_agents/plan/function.py:
##########
@@ -141,3 +141,9 @@ def __call__(self, *args: Tuple[Any, ...], **kwargs:
Dict[str, Any]) -> Any:
def check_signature(self, *args: Tuple[Any, ...]) -> None:
"""Check function signature is legal or not."""
+
+
+def call_python_function(module: str, qualname: str, func_args: Tuple[Any,
...]) -> Any:
+ """Used to call a Python function in the Pemja environment."""
+ func = PythonFunction(module=module, qualname=qualname)
Review Comment:
Thanks for the feedback! You're absolutely right—repeatedly creating
PythonFunction instances could lead to unnecessary overhead. I've created a
follow-up issue to track this optimization: [Issue
#46](https://github.com/apache/flink-agents/issues/46).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
