davidradl commented on code in PR #26667:
URL: https://github.com/apache/flink/pull/26667#discussion_r2177641780
##########
flink-table/flink-table-common/src/test/java/org/apache/flink/table/factories/TestModelProviderFactory.java:
##########
@@ -77,6 +76,7 @@ public Set<ConfigOption<?>> requiredOptions() {
public Set<ConfigOption<?>> optionalOptions() {
Set<ConfigOption<?>> options = new HashSet<>();
options.add(MODEL_VERSION);
+ options.add(TASK);
Review Comment:
I am curious about this test, you have added task as a config option to a
test model provider factory. I notice that
`OpenAIModelProviderFactory implements ModelProviderFactory` should this not
pickup the task in the same way as the test here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
