gustavodemorais commented on code in PR #26734:
URL: https://github.com/apache/flink/pull/26734#discussion_r2179551653
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/plan/nodes/physical/stream/StreamPhysicalMultiJoin.java:
##########
@@ -177,7 +178,7 @@ public ExecNode<?> translateToExecNode() {
inputUpsertKeys,
Collections.emptyMap(), // TODO Enable hint-based state ttl.
See ticket
// TODO https://issues.apache.org/jira/browse/FLINK-37936
- inputs.stream().map(i ->
InputProperty.DEFAULT).collect(Collectors.toList()),
+ inputProperties,
Review Comment:
Yes, I felt the same. Binary joins just use the default input but that looks
wrong on the compiled plan. Let me take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]